Move underlying code of publishToConfluence into class #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dtc-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
thanx for this contribution! |
|
@rdmueller If you don't mind, you can merge now. When I have time to write some tests, I will create another PR. But for me, the changes just work fine. |
|
Thanks for the good work! I will take a look and then merge it. Apparently I waited because of the draft mode so far 😊🖖 |
PacoVK
requested changes
May 31, 2024
The main part of publishToConfluence was executed in an groovy script, which was evaluated from the Gradle task. To increase developability of the feature, move the code from the script into an actual Groovy class and call it from the Gradle task.
seflue
force-pushed
the
refactor/asciidoc2confluence
branch
from
0542e5e
to
6c0b6fb
Compare
PacoVK
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
The main part of publishToConfluence was executed in a Groovy script, which was evaluated from the Gradle task.
To increase developability of the feature, move the code from the script into an actual Groovy class and call it from the Gradle task.
Motivation
I create this as a draft PR. If you relate with the idea, please give me a hint. I then would actually use the opportunity to make the new class a bit more testable and add some tests.
Because I didn't found any tests for publishToConfluence, I just tested it out with a testspace in the Confluence Cloud instance I have access to. How do you actually tested this in the past? Is there a collection of fixtures I missed?
The motivation behind this PR is, that I am going to use DocToolChain quite often in the upcoming future (especially the "publishToConfluence" feature). I learned about it in a workshop @rdmueller gave last year and introduced it in my current project. Because I love to improve the tools I am using, I would like to contribute to DocToolChain.