suggested changes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests do use std::sync::Arc, so move them into an integration tests file, so that they still build with std.
|
Hey @oconnor663 I am very sorry, I did not see your PR until now. I am currently organizing RustFest.eu in Barcelona. Is there any chance that you are here too? Cheers, |
|
Alas no. Believe it or not I haven't been to any Rust conventions yet. |
|
If you are in the mood, we have a live stream: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for a big PR with several commits. I would've split these into separate PRs, except that they depend on each other. This overlaps with some of what was discussed in #3. I haven't made anything
unsafe, though, since that's a bigger decision for the crate.That said, is it possible this crate should be deprecated in favor of https://crates.io/crates/scopeguard? If so, maybe it would be appropriate to put a link in the README or something like that.