Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make federated client more robust #8351

Merged
merged 2 commits into from Oct 18, 2022
Merged

Make federated client more robust #8351

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fac6ea
Make federated client more robust
rongou Oct 17, 2022
40ae710
Merge remote-tracking branch 'upstream/master' into more-robust-client
rongou Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions plugin/federated/federated_client.h
View file
Open in desktop
Expand Up @@ -28,8 +28,11 @@ class FederatedClient {
options.pem_cert_chain = client_cert;
grpc::ChannelArguments args;
args.SetMaxReceiveMessageSize(std::numeric_limits<int>::max());
return Federated::NewStub(
grpc::CreateCustomChannel(server_address, grpc::SslCredentials(options), args));
auto channel =
grpc::CreateCustomChannel(server_address, grpc::SslCredentials(options), args);
channel->WaitForConnected(
gpr_time_add(gpr_now(GPR_CLOCK_REALTIME), gpr_time_from_seconds(60, GPR_TIMESPAN)));
return Federated::NewStub(channel);
}()},
rank_{rank} {}

Expand All @@ -51,6 +54,7 @@ class FederatedClient {

AllgatherReply reply;
grpc::ClientContext context;
context.set_wait_for_ready(true);
grpc::Status status = stub_->Allgather(&context, request, &reply);

if (status.ok()) {
Expand All @@ -72,6 +76,7 @@ class FederatedClient {

AllreduceReply reply;
grpc::ClientContext context;
context.set_wait_for_ready(true);
grpc::Status status = stub_->Allreduce(&context, request, &reply);

if (status.ok()) {
Expand All @@ -91,6 +96,7 @@ class FederatedClient {

BroadcastReply reply;
grpc::ClientContext context;
context.set_wait_for_ready(true);
grpc::Status status = stub_->Broadcast(&context, request, &reply);

if (status.ok()) {
Expand Down