Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for improving Windows networking compatibility. #8234

Merged
merged 2 commits into from Sep 10, 2022
Merged

Prepare for improving Windows networking compatibility. #8234

merged 2 commits into from Sep 10, 2022

Commits on Sep 8, 2022

  1. Prepare for improving Windows networking compatibility. 

    * Include dmlc filesystem indirectly as dmlc/filesystem.h includes windows.h, which
  conflicts with winsock2.h
* Define `NOMINMAX` conditionally.
* Link the winsock library when mysys32 is used.
* Add config file for read the doc.
    @trivialfis
    trivialfis committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    de86f22 View commit details
    Browse the repository at this point in the history

  2. Use macro guard, add comment.

    @trivialfis
    trivialfis committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    33f5f23 View commit details
    Browse the repository at this point in the history