Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor split valuation kernel #8073

Merged
merged 12 commits into from Jul 21, 2022
Merged

Refactor split valuation kernel #8073

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
197ce75
Use single precision, use pointers instead of span.
RAMitchell Jul 5, 2022
f3abe81
Reorganise explit evaluation code.
RAMitchell Jul 6, 2022
de8d6da
Avoid copying gradstats
RAMitchell Jul 9, 2022
4fe386c
Better reduce
RAMitchell Jul 9, 2022
31e4845
72 Register version.
RAMitchell Jul 11, 2022
dbcadbc
Lint, remove benchmark
RAMitchell Jul 14, 2022
ec024e3
Merge branch 'master' of github.com:dmlc/xgboost into eval3
RAMitchell Jul 14, 2022
c63f94e
Clang tidy
RAMitchell Jul 18, 2022
a5cc7c1
Fix test failure.
RAMitchell Jul 18, 2022
fe08cfb
Guard against NaN in gain calculation.
RAMitchell Jul 19, 2022
0c9ea5d
More comments.
RAMitchell Jul 21, 2022
52b10ac
Remove unused template parameter.
RAMitchell Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/device_helpers.cuh
View file
Open in desktop
Expand Up @@ -1949,7 +1949,7 @@ class LDGIterator {
const T *ptr_;

public:
explicit LDGIterator(const T *ptr) : ptr_(ptr) {}
XGBOOST_DEVICE explicit LDGIterator(const T *ptr) : ptr_(ptr) {}
__device__ T operator[](std::size_t idx) const {
DeviceWordT tmp[kNumWords];
static_assert(sizeof(tmp) == sizeof(T), "Expect sizes to be equal.");
Expand Down