Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maximum category in sketch. #7853

Merged
merged 13 commits into from May 5, 2022
Merged

Use maximum category in sketch. #7853

merged 13 commits into from May 5, 2022

Commits on Apr 29, 2022

  1. Use max cat instead.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    915d728 View commit details
    Browse the repository at this point in the history

  2. GPU.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    6bb12e2 View commit details
    Browse the repository at this point in the history

  3. Fixes.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    1f40cbf View commit details
    Browse the repository at this point in the history

  4. Test.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    4e82d5a View commit details
    Browse the repository at this point in the history

  5. Use contructor.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    759ef91 View commit details
    Browse the repository at this point in the history

  6. Use normal discard iter.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    f1971e1 View commit details
    Browse the repository at this point in the history

  7. Revert "Use contructor." 

    This reverts commit 759ef91.
    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    2550b62 View commit details
    Browse the repository at this point in the history

  8. Fuse it into a single call.

    @trivialfis
    trivialfis committed Apr 29, 2022
    Copy the full SHA
    a788dcf View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Simplify the code.

    @trivialfis
    trivialfis committed Apr 30, 2022
    Copy the full SHA
    fe22620 View commit details
    Browse the repository at this point in the history

  2. Check max cat.

    @trivialfis
    trivialfis committed Apr 30, 2022
    Copy the full SHA
    d16aac5 View commit details
    Browse the repository at this point in the history

  3. Assign.

    @trivialfis
    trivialfis committed Apr 30, 2022
    Copy the full SHA
    4094515 View commit details
    Browse the repository at this point in the history

  4. Remove assert

    @trivialfis
    trivialfis committed Apr 30, 2022
    Copy the full SHA
    7510c34 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'jiaming/fix-cat-max' into fix-cat-max

    @trivialfis
    trivialfis committed Apr 30, 2022
    Copy the full SHA
    2cba3cb View commit details
    Browse the repository at this point in the history