[jvm-packages] model loading should be compatible with old models #7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the parameters not used, XGBoost should delete them, instead of keeping it, which will cause some issue for the old model. For example, the kill_spark_context_on_worker_failure is deleted, but when loading the model saved in 1.6.0, (in which has kill_spark_context_on_worker_failure parameter). XGBoost will throw an exception
|
@trivialfis , this PR should also be back-ported to 1.6.1 Thx |
This was referenced Apr 26, 2022
Closed
trivialfis
approved these changes
Apr 27, 2022
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Apr 29, 2022
trivialfis
added a commit
that referenced
this pull request
Apr 29, 2022
* [jvm-packages] move the dmatrix building into rabit context (#7823) This fixes the QuantileDeviceDMatrix in distributed environment. * [doc] update the jvm tutorial to 1.6.1 [skip ci] (#7834) * [Breaking][jvm-packages] Use barrier execution mode (#7836) With the introduction of the barrier execution mode. we don't need to kill SparkContext when some xgboost tasks failed. Instead, Spark will handle the errors for us. So in this PR, `killSparkContextOnWorkerFailure` parameter is deleted. * [doc] remove the doc about killing SparkContext [skip ci] (#7840) * [jvm-package] remove the coalesce in barrier mode (#7846) * [jvm-packages] Fix model compatibility (#7845) * Ignore all Java exceptions when looking for Linux musl support (#7844) Co-authored-by: Bobby Wang <wbo4958@gmail.com> Co-authored-by: Michael Allman <msa@allman.ms>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the parameters not used, XGBoost should delete them, instead of
keeping it, which will cause some issue for the old model.
For example, the kill_spark_context_on_worker_failure is deleted,
but when loading the model saved in 1.6.0, (in which has
kill_spark_context_on_worker_failure parameter).
XGBoost will throw an exception