New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rank Demo Not Working #2694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2694 +/- ##
=========================================
Coverage 42.84% 42.84%
Complexity 185 185
=========================================
Files 150 150
Lines 11306 11306
Branches 1139 1139
=========================================
Hits 4844 4844
Misses 6137 6137
Partials 325 325 Continue to review full report at Codecov.
|
hi yunni. I checkout the version you fixed("The root cause is that learner -> gbm_ is loaded after learner get configured. "). while I run the bash "sh runexp.sh", program goes core dump. |
Interesting. It runs totally fine on my computer. |
I am unfamiliar with cmake, then spent hours to find a way modify CMakelist.txt for debug info, Finally I give up, by adding '-g' in Makefile directly. I get backtrace infos as fallow: |
Interesting. I got the same error when I ran it for the first time but it's fixed on both my Ubuntu and Mac after applying this PR. @qiugen Would you help me on 2 things? |
(1) OS info |
Currently, the rank demo is broken. There are 2 issues with it:
learner -> gbm_
is loaded afterlearner
get configured. As a result,learner -> gbm_ -> predictor
is not initialized.Also, it seems the tests for ranking is not covered very well. I'll probably create a follow-up PR to add more unit tests for ranking.