Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nvtx. #10227

Merged
merged 1 commit into from Apr 28, 2024
Merged

Update nvtx. #10227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/Utils.cmake
View file
Open in desktop
Expand Up @@ -289,7 +289,7 @@ macro(xgboost_target_link_libraries target)
endif()

if(USE_NVTX)
target_link_libraries(${target} PRIVATE CUDA::nvToolsExt)
target_link_libraries(${target} PRIVATE CUDA::nvtx3)
endif()

if(MINGW)
Expand Down
10 changes: 3 additions & 7 deletions src/common/timer.cc
View file
Open in desktop
Expand Up @@ -8,12 +8,10 @@
#include "../collective/communicator-inl.h"

#if defined(XGBOOST_USE_NVTX)
#include <nvToolsExt.h>
#include <nvtx3/nvToolsExt.h>
#endif // defined(XGBOOST_USE_NVTX)

namespace xgboost {
namespace common {

namespace xgboost::common {
void Monitor::Start(std::string const &name) {
if (ConsoleLogger::ShouldLog(ConsoleLogger::LV::kDebug)) {
auto &stats = statistics_map_[name];
Expand Down Expand Up @@ -66,6 +64,4 @@ void Monitor::Print() const {
LOG(CONSOLE) << "======== Monitor (" << rank << "): " << label_ << " ========";
this->PrintStatistics(stat_map);
}

} // namespace common
} // namespace xgboost
} // namespace xgboost::common
1 change: 0 additions & 1 deletion tests/cpp/CMakeLists.txt
View file
Open in desktop
Expand Up @@ -59,7 +59,6 @@ endif()
target_sources(testxgboost PRIVATE ${TEST_SOURCES} ${xgboost_SOURCE_DIR}/plugin/example/custom_obj.cc)

if(USE_CUDA AND PLUGIN_RMM)
find_package(CUDA)
target_include_directories(testxgboost PRIVATE ${CUDA_INCLUDE_DIRS})
endif()

Expand Down