[pyspark] Implement SparkXGBRanker estimator #8172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @trivialfis @wbo4958 Thank you ! |
|
Apologies for the delay, will take a deeper look tomorrow. |
|
CC @trivialfis @wbo4958 Thanks! |
trivialfis
approved these changes
Aug 22, 2022
|
|
||
| class SparkXGBRanker(_SparkXGBEstimator): | ||
| """SparkXGBRanker is a PySpark ML estimator. It implements the XGBoost | ||
| classification algorithm based on XGBoost python library, and it can be used in |
There was a problem hiding this comment.
Should this be It implements the XGBoost **ranking** algorithm based on XGBoost python library instead of classification algorithm? I noticed that there are quite a few references to classification left behind in this block comment... should they and the example provided below be updated to ranking so the documentation comes out right?
Just to avoid confusion for new users like me trying to use this new estimator.
There was a problem hiding this comment.
@WeichenXu123 Would you like to open a fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8110
Implement SparkXGBRanker estimator.