Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xgboost spark: Support XGBRanker #8110

Closed
WeichenXu123 opened this issue Jul 22, 2022 · 12 comments · Fixed by #8172
Closed

Xgboost spark: Support XGBRanker #8110

WeichenXu123 opened this issue Jul 22, 2022 · 12 comments · Fixed by #8172

Comments

@WeichenXu123
Copy link
Contributor

Xgboost spark: Support XGBRanker

@WeichenXu123
Copy link
Contributor Author

@trivialfis @wbo4958 Do you have time to add this feature ? :)

@WeichenXu123
Copy link
Contributor Author

@wbo4958 Do you have time to implement this feature ? @mengxr hopes this feature to go into xgboost 2.0.
Thanks!

@wbo4958
Copy link
Contributor

wbo4958 commented Aug 9, 2022

Hi @WeichenXu123, I am pretty busy recently. I can't guarantee that I can make it in xgboost 2.0

@WeichenXu123
Copy link
Contributor Author

@wbo4958 Understood. I can do it instead. Could you give the ETA of xgboost 2.0 releasing ?

@WeichenXu123
Copy link
Contributor Author

@dbczumar Heads-up: I might need to spend some additional time to work on this because of above reason. :)

@trivialfis
Copy link
Member

We are doing feature-based releases.

@WeichenXu123
Copy link
Contributor Author

WeichenXu123 commented Aug 11, 2022

@trivialfis I have a question, in XGBRanker distributed training, shall we ensure each group training examples being put in the same worker data split ? And does training examples need to be sorted by "qid" first ?
(I will use "qid" not "group" param when constructing DMatrix)

@trivialfis
Copy link
Member

Apologies for missing the thread.

And does training examples need to be sorted by "qid" first ?

yes.

shall we ensure each group training examples being put in the same worker data split

No

@wbo4958
Copy link
Contributor

wbo4958 commented Aug 23, 2022

@WeichenXu123 @trivialfis Sorry, I didn't see #8172 has sorted the qid first? please correct me.

@trivialfis
Copy link
Member

Users can have it sorted. Otherwise there will be an error in c++.

@silpara
Copy link

silpara commented Jan 17, 2023

I don't see any documentation but SparkXGBRanker class is implemented at https://github.com/dmlc/xgboost/blob/master/python-package/xgboost/spark/estimator.py. Is it ready for use?

@trivialfis
Copy link
Member

Opened a PR for the doc #8692 .

It's currently experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants