Remove some warnings from clang. (#7533)

* Unused variable. * Unnecessary virtual function.
dmlc · Jan 4, 2022 · eea094e · eea094e
1 parent ec56d58
commit eea094e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/include/xgboost/json_io.h b/include/xgboost/json_io.h
@@ -115,12 +115,10 @@ class JsonReader {
 class JsonWriter {
   static constexpr size_t kIndentSize = 2;
 
-  size_t n_spaces_;
   std::vector<char>* stream_;
 
  public:
-  explicit JsonWriter(std::vector<char>* stream) :
-      n_spaces_{0}, stream_{stream} {}
+  explicit JsonWriter(std::vector<char>* stream) : stream_{stream} {}
 
   virtual ~JsonWriter() = default;
 

diff --git a/src/c_api/c_api_utils.h b/src/c_api/c_api_utils.h
@@ -165,9 +165,9 @@ inline float GetMissing(Json const &config) {
 
 // Safe guard some global variables from being changed by XGBoost.
 class XGBoostAPIGuard {
+#if defined(XGBOOST_USE_CUDA)
   int32_t device_id_ {0};
 
-#if defined(XGBOOST_USE_CUDA)
   void SetGPUAttribute();
   void RestoreGPUAttribute();
 #else

diff --git a/src/tree/updater_quantile_hist.h b/src/tree/updater_quantile_hist.h
@@ -166,11 +166,8 @@ class QuantileHistMaker: public TreeUpdater {
       builder_monitor_.Init("Quantile::Builder");
     }
     // update one tree, growing
-    virtual void Update(const GHistIndexMatrix& gmat,
-                        const ColumnMatrix& column_matrix,
-                        HostDeviceVector<GradientPair>* gpair,
-                        DMatrix* p_fmat,
-                        RegTree* p_tree);
+    void Update(const GHistIndexMatrix& gmat, const ColumnMatrix& column_matrix,
+                HostDeviceVector<GradientPair>* gpair, DMatrix* p_fmat, RegTree* p_tree);
 
     bool UpdatePredictionCache(const DMatrix* data,
                                linalg::VectorView<float> out_preds);