Review comments.

dmlc · Jun 29, 2022 · 3cd5e41 · 3cd5e41
1 parent 9de0692
commit 3cd5e41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/common/device_helpers.cuh b/src/common/device_helpers.cuh
@@ -1952,6 +1952,7 @@ class LDGIterator {
   explicit LDGIterator(const T *ptr) : ptr_(ptr) {}
   __device__ T operator[](std::size_t idx) const {
     DeviceWordT tmp[kNumWords];
+    static_assert(sizeof(tmp) == sizeof(T), "Expect sizes to be equal.");
 #pragma unroll
     for (int i = 0; i < kNumWords; i++) {
       tmp[i] = __ldg(reinterpret_cast<const DeviceWordT *>(ptr_ + idx) + i);

diff --git a/src/tree/updater_gpu_hist.cu b/src/tree/updater_gpu_hist.cu
@@ -410,6 +410,9 @@ struct GPUHistMakerDevice {
                         HostDeviceVector<bst_node_t>* p_out_position) {
     // Prediction cache will not be used with external memory
     if (!p_fmat->SingleColBlock()) {
+      if (task.UpdateTreeLeaf()) {
+        LOG(FATAL) << "Current objective function can not be used with external memory.";
+      }
       p_out_position->Resize(0);
       update_predictions.clear();
       return;