Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[TOOL] add back diagnose script #1551

Merged
merged 1 commit into from
Apr 22, 2021
Merged

[TOOL] add back diagnose script #1551

merged 1 commit into from
Apr 22, 2021

Conversation

szha
Copy link
Member

@szha szha commented Apr 14, 2021

Signed-off-by: Sheng Zha zhasheng@amazon.com

Description

add back diagnose script used for issue reporting

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • add back diagnose.py from 0.x

Comments

cc @dmlc/gluon-nlp-team

Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@szha szha requested a review from a team as a code owner April 14, 2021 23:20
@github-actions
Copy link

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1551 (cdaa2ec) into master (1326258) will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
- Coverage   82.20%   81.90%   -0.30%     
==========================================
  Files          68       68              
  Lines        8540     8540              
==========================================
- Hits         7020     6995      -25     
- Misses       1520     1545      +25     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/gluonnlp/data/loading.py 76.64% <0.00%> (-7.30%) ⬇️
src/gluonnlp/data/filtering.py 78.26% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff0519...cdaa2ec. Read the comment docs.

@szha szha requested a review from barry-jin April 21, 2021 23:14
Copy link
Contributor

@barry-jin barry-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha szha merged commit 5122e84 into dmlc:master Apr 22, 2021
@szha szha deleted the diagnose branch April 22, 2021 00:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants