[GraphBolt] Fix blocks in minibatch when facing with empty edges in subgraph.
#7413
+103
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
Rhett-Ying
reviewed
May 16, 2024
| relation: gb.CSCFormatBase( | ||
| indptr=torch.tensor([0, 1, 2]), indices=torch.tensor([1, 0]) | ||
| ), | ||
| reverse_relation: gb.CSCFormatBase( |
There was a problem hiding this comment.
so FusedCSCSamplingGraph.sample_neighbors() always returns sampled_csc for each edge type even it's empty? Could we mention this in docstring or documentation? probably in sample_neighbors()?
There was a problem hiding this comment.
Yes. Let me add docstring.
added 3 commits
May 16, 2024 07:00
Rhett-Ying
reviewed
May 16, 2024
python/dgl/graphbolt/minibatch.py
Outdated
| @@ -209,6 +209,7 @@ def cast_to_minimum_dtype(v: CSCFormatBase): | |||
| ), | |||
| ) | |||
| for etype, v in subgraph.sampled_csc.items() | |||
| if len(v.indices) > 0 | |||
There was a problem hiding this comment.
homograph could return empty graph as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related to #7410
TODO:
seedsstill occurs in src_node_type of edges, it will always be passed down.Checklist
Please feel free to remove inapplicable items for your PR.
Changes