Fix containerdServiceOpt type #54
Open
+17,015
−6,299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f695e98. Signed-off-by: Tibor Vass <tibor@docker.com>
This reverts commit 0811297. Signed-off-by: Tibor Vass <tibor@docker.com>
This reverts commit f23a51a. Signed-off-by: Tibor Vass <tibor@docker.com>
Manifest v2 schema1 was deprecated in 4866f5139a1 and this commit removes the push code for v2 schema1. Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Use cache for delete and listing images Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Fix conflict and update removal to use cache and not stores. Layer removal is still missing. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Unpack and delete layers Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Updates info functions to query the containerd image cache. Updates related call stack to pass down context. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Anda Xu <axu@knox.edu>
Fix dangling image management to not rely on reference parsing Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Fix layer references being taken on startup Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Uses containerd client to push. Temporarily resolves current platform on push to match current behavior. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Lookup images without using caching Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Adds equivalent label as the snapshotter gc label Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Anda Xu <axu@knox.edu>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Anda Xu <axu@knox.edu>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Make layer stores multiplatform and allow configuring multiple ordered by preference. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Support for multiple unpacks Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Filter pull artifacts by platform while pulling all manifests and configs. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Anda Xu <axu@knox.edu>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
The entire package is now deprecated, revert temporary changes. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Anda Xu <axu@knox.edu>
Fix build Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
This is to avoid nil pointer dereference. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This migrates image store to containerd. To test: # sudo DOCKER_MIGRATE_IMAGE_STORE=da ./bundles/dynbinary-daemon/dockerd-dev To re-test: # ctr -n moby image ls -q | xargs ctr -n moby image rm # ctr -n moby content ls -q | xargs ctr -n moby content rm TODO: - find a better place for this code - maybe some tests? Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Anda Xu <axu@knox.edu>
fix already exists error during image tagging Signed-off-by: Anda Xu <axu@knox.edu>
Remove image store instantiation from image service Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Move logic to image service and merge with cache loading. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Replace use of image id with descriptor Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Update load to use full image name annotation Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Prevent panics on unimplemented code and remove unnecessary lookups on commit. Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Sam Whited <sam@samwhited.com>
dmcgowan
force-pushed
the
containerd-integration
branch
3 times, most recently
from
2bb3716
to
30fb3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix to one of the types in the service tests.