extract PreferencesBasedStorageHandler from StorageHandlerImpl #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the abstract class PreferencesBasedStorageHandler can easely be subclassed by a client to use another means than Gson for serialization
|
Maybe this change is a bit far fetched. But it nicely separates the usage of GSON for serialization/deserialization from the usage of the java Preferences API. |
martinfrancois
suggested changes
Aug 24, 2019
There was a problem hiding this comment.
I agree, although there is no report of someone needing such a feature at the moment, I could see maybe some special objects not being properly serialized by default by GSON, which would require some kind of customization, which would be made possible by this PR. I like the idea!
Just added a small comment, the rest looks good!
preferencesfx/src/main/java/com/dlsc/preferencesfx/util/PreferencesBasedStorageHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the abstract class PreferencesBasedStorageHandler can easely be subclassed by a client to use another means than Gson for serialization
PR Checklist
What is the current behavior?
behavior has not changed
What is the new behavior?
behavior has not changed
Fixes/Implements/Closes #[Issue Number].
Breaking Change:
no breaking change. New class added though