Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix javadoc errors #90

Merged
merged 3 commits into from Aug 25, 2019
Merged

fix javadoc errors #90

merged 3 commits into from Aug 25, 2019

Conversation

sclassen
Copy link
Contributor

This PR fixes all JavaDoc errors.
The errors in the class Ascii are not fixed as this class is removed by #89

martinfrancois
martinfrancois suggested changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@martinfrancois martinfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! Just fix the small issue mentioned, then it should be good to go.

preferencesfx/src/main/java/com/dlsc/preferencesfx/PreferencesFx.java Outdated Show resolved Hide resolved
martinfrancois
martinfrancois approved these changes Aug 25, 2019
View reviewed changes
Copy link
Contributor

@martinfrancois martinfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@martinfrancois martinfrancois merged commit a142d97 into dlsc-software-consulting-gmbh:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfrancois martinfrancois martinfrancois approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sclassen @martinfrancois