WIP: Convert from using apischema to pydantic #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
reviewed
Oct 27, 2022
coretl
reviewed
Oct 27, 2022
| "then the end and start of consecutive iterations of Spec will have no gap" | ||
| ), | ||
| ] = True | ||
| num: int = Field(min=1, description="Number of frames to produce") |
There was a problem hiding this comment.
Can we create Field instances up front and use them in two separate dataclasses?
There was a problem hiding this comment.
Probably, but there have been issues with doing so in the past (pydantic/pydantic#1412), so I wanted to get this working without first of all.
coretl
reviewed
Oct 27, 2022
|
Will close in favour of #56 when discussions here resolved. |
|
Superseded by #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
apischemaas a dependency and usepydanticinsteadpydantic.dataclasses.dataclassinstead ofdataclasses.dataclass