Add input linter when asking for password #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwager
reviewed
Sep 16, 2022
| off_by_default = False | ||
|
|
||
| _code = 'DUO139' | ||
| _error_tmpl = 'DUO139 avoid using "input" to ask for password' |
There was a problem hiding this comment.
I try to include the remediation in the message if it's short enough. How does this sound?
DUO139 avoid using "input" to ask for password, prefer "getpass.getpass"
| @@ -42,6 +42,7 @@ Dlint uses a simple, folder-based hierarchy written in [Markdown](https://en.wik | |||
| - [`DUO136` `BadXmlsecModuleAttributeUseLinter` insecure "xmlsec" attribute use](https://github.com/dlint-py/dlint/blob/master/docs/linters/DUO136.md) | |||
| - [`DUO137` `BadItsDangerousKwargUseLinter` insecure "itsdangerous" use allowing empty signing](https://github.com/dlint-py/dlint/blob/master/docs/linters/DUO137.md) | |||
| - [`DUO138` `BadReCatastrophicUseLinter` catastrophic "re" usage - denial-of-service possible](https://github.com/dlint-py/dlint/blob/master/docs/linters/DUO138.md) | |||
| - todo | |||
There was a problem hiding this comment.
Looks like this needs a bump 👍
mschwager
reviewed
Sep 16, 2022
|
|
||
| def _get_arg_or_kwarg(self, node): | ||
| if node.args: | ||
| return node.args[0].value |
There was a problem hiding this comment.
You should also check that node.args and node.keywords are not empty before checking [0]. This would produce a runtime error in the code because input takes 1 argument, but you never know what code you'll find in the wild. In other words, static analysis will often see code that hasn't been executed, or has all kinds of weird bugs, so it's best to be defensive :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
The goal is to detect when a user uses the built-in
inputfunction with an arg or kwarg of string containing "password". Unit tests demonstrate when this may be a false positive, such asinput("Please enter your name. Please do not enter your password")First pass attempt, would love feedback.