Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flake8 v4 #37

Merged
merged 3 commits into from Oct 27, 2021
Merged

Support flake8 v4 #37

merged 3 commits into from Oct 27, 2021

Conversation

wwuck
Copy link
Contributor

@wwuck wwuck commented Oct 12, 2021

Fixes #36

@mschwager
Copy link
Contributor

Hi there,

Thanks for catching this. It looks like we'll need to drop Python 2.7 support before moving forward with this. Here's the original issue for that: #3. I'll handle that, and updating CI providers, then we can rebase here and get this change in 👍

@mschwager
Copy link
Contributor

Hi again, I removed Python 2.7 support so we should be good to move forward here. I also pulled in the extend_select and extended_default_ignore changes myself to get CI passing. If you'd like to update this PR to just bump requirements.txt, I can pull it in and release a new version of Dlint.

@wwuck
Copy link
Contributor Author

wwuck commented Oct 25, 2021

Thanks for the update. Did you want me to revert the test change?

@mschwager
Copy link
Contributor

Thanks for the update. Did you want me to revert the test change?

Yes, please remove the test since we can't guarantee it'll pass for all supported versions of flake8 (extend_select wasn't added until 4.0.0, and we're claiming 3.6.0 minimum here).

@wwuck
Copy link
Contributor Author

wwuck commented Oct 26, 2021

Done

@mschwager mschwager merged commit d23f859 into dlint-py:master Oct 27, 2021
@mschwager
Copy link
Contributor

Great, thanks again for noticing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support flake8>=4
2 participants