Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter to detect input asking for password #16

Open
mschwager opened this issue Jan 30, 2020 · 1 comment · May be fixed by #54
Open

Add linter to detect input asking for password #16

mschwager opened this issue Jan 30, 2020 · 1 comment · May be fixed by #54

Comments

@mschwager
Copy link
Contributor

Bad:

input("Password: ")

Good:

getpass.getpass("Password: ")

See getpass.

We can probably just look for input calls that contain the string literal 'password'.
@mschwager
Copy link
Contributor Author

Note this may be somewhat moot since we're already searching for all input usage in DUO108. However, six.moves.input and input in Python > 3.0 are whitelisted, so probably still worth it.

@clavedeluna clavedeluna linked a pull request Sep 12, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add input linter when asking for password clavedeluna/dlint
1 participant
@mschwager