Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing starlette template handling #75

Merged
merged 1 commit into from Feb 25, 2022
Merged

Fixing starlette template handling #75

merged 1 commit into from Feb 25, 2022

Conversation

djpugh
Copy link
Owner

@djpugh djpugh commented Feb 25, 2022

Closes #72 - switches to overriding the env attribute rather than via getenv, due to encode/starlette#1218

@github-actions github-actions bot added the fix label Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #75 (279777f) into main (4089ca0) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   42.95%   42.98%   +0.03%     
==========================================
  Files          29       29              
  Lines        1413     1412       -1     
==========================================
  Hits          607      607              
+ Misses        806      805       -1     
Flag Coverage Δ
tests 42.98% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fastapi_aad_auth/ui/jinja.py 42.85% <33.33%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4089ca0...279777f. Read the comment docs.

@djpugh djpugh closed this Feb 25, 2022
@djpugh djpugh deleted the fix/72 branch February 25, 2022 17:12
@djpugh djpugh restored the fix/72 branch February 25, 2022 17:13
@djpugh djpugh reopened this Feb 25, 2022
@djpugh djpugh merged commit 798aba6 into main Feb 25, 2022
@djpugh djpugh deleted the fix/72 branch February 25, 2022 17:13
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@robintw
Copy link
Contributor

robintw commented Mar 16, 2022

@djpugh Is it possible to release a new version to PyPI which includes this fix? I'm running into issues with pinning the fastapi version to 0.69 to get around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/login page broken after upgrading to fastapi 0.70.0
2 participants