Switched to Into<Option<T>> for parameters in Builder #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jan 19, 2024
bb8/src/api.rs
Outdated
| @@ -165,8 +165,11 @@ impl<M: ManageConnection> Builder<M> { | |||
| /// | |||
| /// Defaults to None. | |||
| #[must_use] | |||
| pub fn min_idle(mut self, min_idle: Option<u32>) -> Self { | |||
| self.min_idle = min_idle; | |||
| pub fn min_idle<U>(mut self, min_idle: U) -> Self | |||
There was a problem hiding this comment.
Nit: if we're going to do this, I'd like it spelled min_idle: impl Into<Option<u32>> (same for the others).
There was a problem hiding this comment.
Oh, I had never done it like that, but actually that looks pretty good.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
- Coverage 72.05% 71.97% -0.08%
==========================================
Files 6 6
Lines 594 596 +2
==========================================
+ Hits 428 429 +1
- Misses 166 167 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I know this is minor, but it seems so much nicer for optional parameters in a public API to take
Into<Option<T>>rather than just takingOption<T>. That way the user can just send a value ofTforSome<T>, and of course can still sendNonewhen desired.Thus we could do:
rather than
but,
min_idle(Some(2))andmin_idle(None)still work, so it's all backward compatible.