Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PoolInternals QueueStrategy default #163

Merged
merged 3 commits into from
May 27, 2023

Conversation

zainkabani
Copy link
Contributor

@zainkabani zainkabani commented May 26, 2023

Fixing default for queue strategy

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (935b887) 72.07% compared to head (d24f61b) 72.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files           6        6           
  Lines         598      598           
=======================================
  Hits          431      431           
  Misses        167      167           
Impacted Files Coverage Δ
bb8/src/api.rs 63.79% <ø> (ø)
bb8/src/lib.rs 100.00% <ø> (ø)
bb8/src/internals.rs 92.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zainkabani zainkabani marked this pull request as ready for review May 26, 2023 14:39
@zainkabani
Copy link
Contributor Author

@djc any plans to cut a release for bb8 soon? We're actively using it in our project and would prefer to be in sync with cargo rather than use github.

@djc djc merged commit ad653e0 into djc:main May 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants