Fixed mismatched blacken-docs behavior between CI and pre-commit #18121
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmispelon
changed the title
felixxm
reviewed
May 1, 2024
bmispelon
force-pushed
the
pin-black-version-docs-ci
branch
2 times, most recently
from
f1593fc
to
6f44679
Compare
|
I've made the changes and rebased onto latest |
sarahboyce
force-pushed
the
pin-black-version-docs-ci
branch
from
6f44679
to
9dcdf37
Compare
|
Weird it got missed, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that my PR #18120 was failing on CI but not locally with pre-commit.
I first thought this was due to a
blackversion mismatched between the two tools, so I fixed that (first commit on this PR) but that didn't make the problem go away.In the end I figured out that it was caused by
make black(what the CI eventually calls) using the--rst-literal-blockflag forblacken-docswhich the commit hook didn't use. I fixed that too (2nd commit) and that made the pre-commit hook fail locally on my PR too.