Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket #34417 - Remove unnecessary recreation of foreign key constrains while dropping index. #18116

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Ticket #34417 - Remove unnecessary recreation of foreign key constrains while dropping index. #18116

wants to merge 6 commits into from
+46 −0

Conversation

DevilsAutumn
Copy link
Contributor

Trac ticket number

Ticket #34417
Follow up to : #16922

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@DevilsAutumn DevilsAutumn marked this pull request as draft May 1, 2024 14:38
@DevilsAutumn DevilsAutumn marked this pull request as ready for review May 2, 2024 18:52
@DevilsAutumn DevilsAutumn marked this pull request as draft May 2, 2024 18:52
LilyFoote
LilyFoote reviewed May 3, 2024
View reviewed changes
tests/schema/tests.py Outdated Show resolved Hide resolved
tests/schema/tests.py Outdated Show resolved Hide resolved
tests/schema/tests.py Outdated Show resolved Hide resolved
@DevilsAutumn
Copy link
Contributor Author

I'm struggling to get schema.tests.SchemaTests.test_alter_fk_checks_deferred_constraints test pass on postgres because the field is being both altered and updated inside the same transaction (see #7709). Anyone having any suggestions on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DevilsAutumn @LilyFoote