Used JSON_OBJECT database function on PostgreSQL 16+. #17664
Conversation
| class ArgJoiner: | ||
| def join(self, args): | ||
| args = [" VALUE ".join(arg) for arg in zip(args[::2], args[1::2])] | ||
| return ", ".join(args) | ||
| pairs = zip(args[::2], args[1::2], strict=True) |
There was a problem hiding this comment.
Adding the strict flag here avoids silently dropping the last argument if an odd number of arguments are provided to JSONObject().
|
@ngnpope Thanks 👍 |
felixxm
changed the title
| args = [" VALUE ".join(arg) for arg in zip(args[::2], args[1::2])] | ||
| return ", ".join(args) | ||
| pairs = zip(args[::2], args[1::2], strict=True) | ||
| return ", ".join([" VALUE ".join(pair) for pair in pairs]) |
There was a problem hiding this comment.
I'm late to the party, but something that I usually recommend is to avoid creating a whole list in memory before calling join, since it handles generators very nicely and it uses less memory:
| return ", ".join([" VALUE ".join(pair) for pair in pairs]) | |
| return ", ".join(" VALUE ".join(pair) for pair in pairs) |
There was a problem hiding this comment.
A list comprehension is preferable here as str.join() converts to list internally anyway. It is better performance to provide a list up front.
There was a problem hiding this comment.
Thank you! Now that you mention it, I recall this was already discussed in another Django PR. I need to re-learn this! 📚
Updates
JSONObject()to use the standard SQL functionJSON_OBJECTon PostgreSQL 16+.This makes Oracle and PostgreSQL 16+ share the same implementation.