Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed forms_tests.tests.test_renderers with Jinja 3.1.0+. #15541

Merged
merged 1 commit into from Mar 25, 2022
Merged

Fixed forms_tests.tests.test_renderers with Jinja 3.1.0+. #15541

merged 1 commit into from Mar 25, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 25, 2022 •
edited

@felixxm felixxm changed the title [WIP] Fixed tests with Jinja 3.1.0. Fixed forms_tests.tests.test_renderers with Jinja 3.1.0+. Mar 25, 2022
@felixxm felixxm marked this pull request as ready for review March 25, 2022 06:23
carltongibson
carltongibson approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. 👍 Thanks!

@felixxm
Copy link
Member Author

felixxm commented Mar 25, 2022

@carltongibson Thanks for checking 👍

@felixxm felixxm merged commit 1d9d082 into django:main Mar 25, 2022
@felixxm felixxm deleted the jinja-3.1.0 branch March 25, 2022 07:49
@davidism
Copy link

davidism commented Mar 25, 2022 •
edited

Just saw this reported elsewhere, I'll fix this in Jinja so the final filename gets normalized, and then release 3.1.1. pallets/jinja#1637

@davidism
Copy link

davidism commented Mar 25, 2022 •
edited

Just released 3.1.1.

And sorry, but the fix is going to cause this fix in your tests to fail again. If you still want to test 3.1.0, an alternate fix would be to call pathlib.Path() or os.path.normpath() on both values being compared.

@felixxm
Copy link
Member Author

felixxm commented Mar 26, 2022

@davidism No problem, we will revert, it's just a test fix. Thanks for your efforts 🥇

@felixxm
Copy link
Member Author

felixxm commented Mar 26, 2022

See #15545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@smithdc1 smithdc1 Awaiting requested review from smithdc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @davidism @carltongibson