Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #27060: Extended inspectdb so indexes are added to Meta.indexes. #12712

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Fixed #27060: Extended inspectdb so indexes are added to Meta.indexes. #12712

wants to merge 16 commits into from
+133 −4

Commits on Apr 28, 2023

  1. Add indexes identified in constraints to Meta field in inspection 

    When inspecting tables, the process creates a constraints dict
that identifies indexes. If we have any such indexes, let's add
them to `Meta.indexes` using the base `Index` class.

At this point, it does not support identifying the index type and
substituting in the proper index class, and I don't believe we have
the information at this time to select the right class anyway.

Ref: https://code.djangoproject.com/ticket/27060
    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    a57747a View commit details
    Browse the repository at this point in the history

  2. Add Drew as an author

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    12254d4 View commit details
    Browse the repository at this point in the history

  3. Add support for descending indexes 

    Also add a comment if the type isn't btree
    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1256fcd View commit details
    Browse the repository at this point in the history

  4. Add GIS tests and set default spatialite type to rtree

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ebbc981 View commit details
    Browse the repository at this point in the history

  5. Don't add comment if index is default type

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bc63908 View commit details
    Browse the repository at this point in the history

  6. Skip single-column rtree indexes 

    Let's assume they're default spatial indexes
    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1834d5e View commit details
    Browse the repository at this point in the history

  7. fix isort

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    88fe9c6 View commit details
    Browse the repository at this point in the history

  8. move test to the right class

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    682df00 View commit details
    Browse the repository at this point in the history

  9. try renaming the index

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    1ec84ac View commit details
    Browse the repository at this point in the history

  10. fix index naming

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    453e8fa View commit details
    Browse the repository at this point in the history

  11. remove manual index

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    fb29725 View commit details
    Browse the repository at this point in the history

  12. Add test for ignoring index ordering if the DB doesn't support that

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f2ac2cd View commit details
    Browse the repository at this point in the history

  13. reformat comments to be valid python

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    95c36bc View commit details
    Browse the repository at this point in the history

  14. skip 'spatial' indexes (MySQL)

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    589b857 View commit details
    Browse the repository at this point in the history

  15. Fix line lengths and reformat with black

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    bad8eee View commit details
    Browse the repository at this point in the history

  16. isort

    @drewbrew
    drewbrew committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    6976ecd View commit details
    Browse the repository at this point in the history