Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed timezones tests for PyYAML 5.3+. #12283

Merged
merged 1 commit into from Jan 7, 2020
Merged

Fixed timezones tests for PyYAML 5.3+. #12283

merged 1 commit into from Jan 7, 2020

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jan 7, 2020

Issue with loading timezones was fixed in PyYAML 5.3:

@felixxm felixxm mentioned this pull request Jan 7, 2020
Merged
carltongibson
carltongibson reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fine... question: is it worth our while maintaining support for PyYAML < 5.3? (Why not just bump the test requirement?)

@felixxm
Copy link
Member Author

felixxm commented Jan 7, 2020

@carltongibson We support also older versions of PyYAML, IMO it's good to have test suite working with all supported versions.

@felixxm felixxm merged commit 8be477b into django:master Jan 7, 2020
@felixxm felixxm deleted the pyyaml-5.3 branch January 7, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@felixxm @carltongibson