Skip to content

Commit

Permalink
Refs #27095 -- Fixed test_contained_by_including_F_object when run in…
Browse files Browse the repository at this point in the history
… reverse.

Tests should not rely on auto PKs.

Test regression in 33403bf.
  • Loading branch information
felixxm committed Dec 3, 2020
1 parent 48b4bae commit d746f28
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions tests/postgres_tests/migrations/0002_create_test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class Migration(migrations.Migration):
'field_nested',
ArrayField(ArrayField(models.IntegerField(), size=None, null=True), size=None, null=True),
),
('order', models.IntegerField(null=True)),
],
options={
'required_db_vendor': 'postgresql',
Expand Down
1 change: 1 addition & 0 deletions tests/postgres_tests/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class IntegerArrayModel(PostgreSQLModel):
class NullableIntegerArrayModel(PostgreSQLModel):
field = ArrayField(models.IntegerField(), blank=True, null=True)
field_nested = ArrayField(ArrayField(models.IntegerField(null=True)), null=True)
order = models.IntegerField(null=True)


class CharArrayModel(PostgreSQLModel):
Expand Down
12 changes: 6 additions & 6 deletions tests/postgres_tests/test_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,11 @@ class TestQuerying(PostgreSQLTestCase):
@classmethod
def setUpTestData(cls):
cls.objs = NullableIntegerArrayModel.objects.bulk_create([
NullableIntegerArrayModel(field=[1]),
NullableIntegerArrayModel(field=[2]),
NullableIntegerArrayModel(field=[2, 3]),
NullableIntegerArrayModel(field=[20, 30, 40]),
NullableIntegerArrayModel(field=None),
NullableIntegerArrayModel(order=1, field=[1]),
NullableIntegerArrayModel(order=2, field=[2]),
NullableIntegerArrayModel(order=3, field=[2, 3]),
NullableIntegerArrayModel(order=4, field=[20, 30, 40]),
NullableIntegerArrayModel(order=5, field=None),
])

def test_empty_list(self):
Expand Down Expand Up @@ -304,7 +304,7 @@ def test_contained_by(self):

def test_contained_by_including_F_object(self):
self.assertSequenceEqual(
NullableIntegerArrayModel.objects.filter(field__contained_by=[models.F('id'), 2]),
NullableIntegerArrayModel.objects.filter(field__contained_by=[models.F('order'), 2]),
self.objs[:3],
)

Expand Down

0 comments on commit d746f28

Please sign in to comment.