Unsure about the value of configurable widget colors...

django · Sep 19, 2020 · cd4dbc4 · cd4dbc4
1 parent 1e16bfa
commit cd4dbc4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/django/contrib/admin/static/admin/css/responsive.css b/django/contrib/admin/static/admin/css/responsive.css
@@ -401,7 +401,7 @@ input[type="submit"], button {
     }
 
     .datetimeshortcuts {
-        color: #ccc;
+        color: var(--border-color); /* XXX Redundant, .datetime span also sets #ccc */
     }
 
     .form-row .datetime input.vDateField, .form-row .datetime input.vTimeField {

diff --git a/django/contrib/admin/static/admin/css/widgets.css b/django/contrib/admin/static/admin/css/widgets.css
@@ -268,7 +268,7 @@ p.datetime {
     white-space: nowrap;
     font-weight: normal;
     font-size: 11px;
-    color: #ccc;
+    color: var(--border-color);
 }
 
 .datetime input, .form-row .datetime input.vDateField, .form-row .datetime input.vTimeField {
@@ -406,7 +406,7 @@ span.clearable-file-input label {
 .calendar th {
     padding: 8px 5px;
     background: var(--darkened-bg);
-    border-bottom: 1px solid #ddd;
+    border-bottom: 1px solid var(--border-color);
     font-weight: 400;
     font-size: 12px;
     text-align: center;
@@ -510,8 +510,8 @@ span.clearable-file-input label {
     margin: 0;
     padding: 4px 0;
     font-size: 12px;
-    background: var(--widget-cancel-bg);
-    border-top: 1px solid #ddd;
+    background: #eee;
+    border-top: 1px solid var(--border-color);
     color: var(--body-fg);
 }
 

diff --git a/django/contrib/admin/templates/admin/base.html b/django/contrib/admin/templates/admin/base.html
@@ -71,18 +71,19 @@
   --object-tools-bg: #999;
   --object-tools-hover-bg: var(--secondary);
 
-  --widget-cancel-bg: #eee;
   --selected: #ffc;
 }
 
-/* Purple, just as an experiment to see what's missing */
+/* Purple, just as an experiment to see what's missing *
 :root {
   --primary: #9774d5;
   --secondary: #785cab;
   --link-fg: #7c449b;
   --link-selected-fg: #8f5bb2;
 }
 
+/* */
+
 /* I don't personally like dark mode too much, but helps find missing vars */
 disabled :root {
   --primary-h: 125; /* Original: 200 */