Prepare v3.6 release. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
commented
Dec 15, 2022
CHANGELOG.txt
Outdated
| @@ -1,5 +1,20 @@ | |||
| UNRELEASED | |||
| ---------- | |||
| 3.6.0 (UNRELEASED) | |||
There was a problem hiding this comment.
Date needed before actual release.
|
I think this looks reasonable - can't think of anything else I'd want to pack in. |
carltongibson
force-pushed
the
version-3.6
branch
from
ab7813a
to
07cd333
Compare
|
Hey @andrewgodwin — thanks! I've rebased. Point 3 is ready to go. I just checked, I have PyPI perms, so I can release (likely Tuesday) unless you'd like to do the honours. (Or shout 🛑 :) 🚀 |
smithdc1
reviewed
Dec 15, 2022
carltongibson
force-pushed
the
version-3.6
branch
from
07cd333
to
3d09ad6
Compare
|
Thanks @smithdc1! 🎩 |
carltongibson
force-pushed
the
version-3.6
branch
from
3d09ad6
to
e079839
Compare
|
OK, no-one shouted — I'm going to take that as 🟢 🙂 |
br3ndonland
added a commit
to br3ndonland/inboard
that referenced
this pull request
Dec 29, 2022
`asgiref==3.6.0` introduced a new required `trailers` key to the `asgiref.types.HTTPResponseStartEvent` type. As the django/asgiref#339 code review pointed out, this is a breaking change for type checking, but it was added in a minor release, and not mentioned in the changelog. django/asgiref#339 django/asgiref#362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @andrewgodwin.
I'm looking at putting out a v3.6 that we can use for Django 4.2a1.
I looked through the other PRs. I think they're all in various stages of waiting except #337.
Do you think this is right?
Can you think of anything else you want to add?
Thanks.