Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle broken link for the missing image file #4287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle broken link for the missing image file #4287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/oscar/apps/catalogue/abstract_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,9 @@
self.symlink_missing_image(media_file_path)

def symlink_missing_image(self, media_file_path):
if os.path.islink(media_file_path):
# broken link, remove it to create it anew
os.unlink(media_file_path)

Check warning on line 1521 in src/oscar/apps/catalogue/abstract_models.py

View check run for this annotation

Codecov / codecov/patch

src/oscar/apps/catalogue/abstract_models.py#L1521 

Added line #L1521 was not covered by tests
static_file_path = find("oscar/img/%s" % self.name)
if static_file_path is not None:
try:
Expand Down