Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in has_children value and tests of annotated list extra info #4284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chadys
Copy link
Contributor

@Chadys Chadys commented Apr 23, 2024

There was a typo in has_children computation, the wrong variable is used for the comparison. I also added a test for get_annotated_list's num_to_close and has_children values.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #4284 (fda6d46) into master (204b9a7) will increase coverage by 0.07%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4284      +/-   ##
==========================================
+ Coverage   88.28%   88.36%   +0.07%     
==========================================
  Files         293      293              
  Lines       16046    16095      +49     
==========================================
+ Hits        14166    14222      +56     
+ Misses       1880     1873       -7     
Files Coverage Δ
src/oscar/templatetags/category_tags.py 94.44% <100.00%> (+0.07%) ⬆️

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant