Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basket check id and translation #4283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Chadys
Copy link
Contributor

@Chadys Chadys commented Apr 23, 2024

Fixed a bug about a basket warning message that couldn't be discovered by makemessage as well as fixed the makemessages command in the makefile.
Prevent some access to db properties of the basket when the object is not yet saved and added some test for it

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #4283 (509d068) into master (204b9a7) will decrease coverage by 0.01%.
Report is 11 commits behind head on master.
The diff coverage is 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4283      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.01%     
==========================================
  Files         293      293              
  Lines       16046    15914     -132     
==========================================
- Hits        14166    14048     -118     
+ Misses       1880     1866      -14     
Files Coverage Δ
src/oscar/apps/basket/abstract_models.py 91.49% <90.90%> (-0.18%) ⬇️

... and 185 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant