Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template minor issues #4281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Chadys
Copy link
Contributor

@Chadys Chadys commented Apr 22, 2024

3 little changes (one for each commit):

  • in checkout template, use line object everywhere
  • add consistency to review file location and detail url retrieval
  • make every communication template inherit from corresponding base template file. Some of them where missing the extends.

However for that last one, there is the issue of having Thanks for your interest, The {{ site }} Team in some templates, which is redundant with the base template signature.
Affected files are:

  • oscar/templates/oscar/communication/emails/commtype_product_alert_confirmation_body.html
  • oscar/templates/oscar/communication/emails/commtype_product_alert_confirmation_body.txt
  • oscar/templates/oscar/communication/emails/commtype_product_alert_body.txt
    (Note the inconsistency between product_alert_body text and html content since the aforementioned text is only present in one of them)
    I didn't want to edit translated texts without first asking how this is done for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant