Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use old email to build reset_url on email change #4278

Merged

Conversation

Chadys
Copy link
Contributor

@Chadys Chadys commented Apr 18, 2024

When an user change their email, we execute ProfileUpdateView.send_email_changed_email to alert the old email address of the change. In this alert, we include a reset email link to be able to revert the change.
Problem: since the reset url is built with the old user object, the reset url validation is failing when it is compared to the new user. Building the reset url using the new user object instead fix the issue

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #4278 (2b1bbc2) into master (204b9a7) will increase coverage by 0.07%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4278      +/-   ##
==========================================
+ Coverage   88.28%   88.35%   +0.07%     
==========================================
  Files         293      293              
  Lines       16046    16083      +37     
==========================================
+ Hits        14166    14210      +44     
+ Misses       1880     1873       -7     
Files Coverage Δ
src/oscar/apps/customer/views.py 77.69% <ø> (ø)

... and 5 files with indirect coverage changes

@viggo-devries viggo-devries merged commit 992e1c6 into django-oscar:master Apr 22, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants