fix: use old email to build reset_url on email change #4278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an user change their email, we execute
ProfileUpdateView.send_email_changed_email
to alert the old email address of the change. In this alert, we include a reset email link to be able to revert the change.Problem: since the reset url is built with the old user object, the reset url validation is failing when it is compared to the new user. Building the reset url using the new user object instead fix the issue