Fix get rules from order with option value instead of option code #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viggo-devries
requested changes
Apr 1, 2024
| @@ -698,10 +698,10 @@ def description(self): | |||
| value = attribute.value | |||
| if isinstance(value, list): | |||
| ops.append( | |||
| "%s = '%s'" % (attribute.type, (", ".join([str(v) for v in value]))) | |||
| "%s = '%s'" % (attribute.option.name, (", ".join([str(v) for v in value]))) | |||
There was a problem hiding this comment.
I think this should be attribute.value because the option could be empty
There was a problem hiding this comment.
When you look at another abstract_models. For example at baskets module, it is also like i changed.
viggo-devries
requested changes
Apr 22, 2024
| @@ -55,7 +55,7 @@ def setUp(self): | |||
| upc="1234", | |||
| ) | |||
| product.attr.weight = 3 | |||
| product.full_clean() | |||
| # product.full_clean() | |||
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
+ Coverage 87.84% 88.35% +0.51%
==========================================
Files 291 293 +2
Lines 16145 16083 -62
==========================================
+ Hits 14182 14210 +28
+ Misses 1963 1873 -90
|
viggo-devries
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes showing order lines with the option value instead of the code.
#4263