[FEAT] Add excluded categories in range #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viggo-devries
requested changes
Mar 27, 2024
| # extend filter for parent categories, exclude parent = None | ||
| if ( | ||
| Product.objects.exclude(parent=None) | ||
| .filter(parent__categories__in=expanded_range_categories) |
There was a problem hiding this comment.
why do we check for this? can't we just always add the extra parent query to the exclude?
samar-hassan
force-pushed
the
excluded-categories
branch
from
7eea0b7
to
5f4afca
Compare
specialunderwear
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Includes all products is checked in the range, adding categories in the excluded categories field with remove the related products of those categories from the range.