Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Add a link to the attribute option group list #4257

Conversation

JulienPalard
Copy link
Contributor

@JulienPalard JulienPalard commented Mar 8, 2024

Closes #4256.

It looks like this:

Screenshot 2024-03-08 at 09-00-31 Dashboard Oscar -

and links to the existing list of attribute option group.

The text was already known by gettext (and it's already translated in french at least).

Copy link
Contributor

@viggo-devries viggo-devries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and all seems to work well!

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Merging #4257 (d99bf64) into master (cb93f5e) will increase coverage by 0.51%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4257      +/-   ##
==========================================
+ Coverage   87.84%   88.35%   +0.51%     
==========================================
  Files         291      293       +2     
  Lines       16145    16041     -104     
==========================================
- Hits        14182    14173       -9     
+ Misses       1963     1868      -95     
Files Coverage Δ
src/oscar/defaults.py 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

@JulienPalard
Copy link
Contributor Author

Can I do something to unlock this PR? It looks like some tests are failing but it looks not related to my code (I bet my HTML link can't really break DB transactions?).

@samar-hassan samar-hassan merged commit ed1c9a2 into django-oscar:master Mar 29, 2024
11 of 23 checks passed
@JulienPalard JulienPalard deleted the mdk-dashboard-attribute-option-group branch April 1, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no link from the dashboard to Attribute Option Group list page
3 participants