Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: GitHub Actions: Test on Python v3.12 and Django v5.0 #4213

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 8, 2023

@viggo-devries
Copy link
Contributor

@cclauss the tests and pylint don't pass right now.

@cclauss cclauss marked this pull request as draft January 22, 2024 09:14
@cclauss cclauss changed the title GitHub Actions: Test on Python v3.12 and Django v5.0 DRAFT: GitHub Actions: Test on Python v3.12 and Django v5.0 Jan 22, 2024
@cclauss
Copy link
Contributor Author

cclauss commented Jan 22, 2024

The tests and pylint pass on this pull request but we are blocked by:

@cclauss cclauss closed this Jan 26, 2024
@cclauss cclauss deleted the patch-2 branch January 26, 2024 14:09
@cclauss cclauss restored the patch-2 branch January 26, 2024 15:05
@cclauss cclauss reopened this Jan 26, 2024
@specialunderwear
Copy link
Member

When the lint does not pass, try:
make black

@cclauss
Copy link
Contributor Author

cclauss commented Jan 26, 2024

Yes, but how does one fix codecov/patch on #4230 and #4231?

Facinating that codecov does not complain about #4235!

@cclauss cclauss mentioned this pull request Jan 26, 2024
@viggo-devries
Copy link
Contributor

@cclauss thanks for this. Could you please also change the classifiers in the setup.py?

And I see you also work on django-haystack, any idea when the new version will be out?

Also I just updated django-oscar to work with haystack's generic views. If I had known I would have asked you to review it.
Maybe you can still give it a look? #4187

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #4213 (5a0a88f) into master (cb93f5e) will increase coverage by 0.51%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
+ Coverage   87.84%   88.35%   +0.51%     
==========================================
  Files         291      293       +2     
  Lines       16145    16041     -104     
==========================================
- Hits        14182    14173       -9     
+ Misses       1963     1868      -95     
Files Coverage Δ
src/oscar/apps/payment/abstract_models.py 89.55% <100.00%> (ø)

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants