Update basket stock records when strategy changes #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
References issue: |
|
Actually - this is quite broken because it causes attempted modifications of frozen baskets, I'll have to rethink... |
|
Ok, looking forward to your solution, thnx! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4180 +/- ##
==========================================
+ Coverage 87.84% 88.35% +0.51%
==========================================
Files 291 293 +2
Lines 16145 16045 -100
==========================================
- Hits 14182 14176 -6
+ Misses 1963 1869 -94
|
…into partner_basket # Conflicts: # src/oscar/apps/basket/middleware.py
|
In the end, I went with updating stock records at time of merge baskets, when users log in. Take a look.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.