fix use get_is_discountable instead is_discountable attribute from product #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialunderwear
requested changes
Mar 14, 2023
| @@ -655,7 +655,7 @@ def can_apply_benefit(self, line): | |||
| """ | |||
| Determines whether the benefit can be applied to a given basket line | |||
| """ | |||
| return line.stockrecord and line.product.is_discountable | |||
| return line.stockrecord and line.product.get_is_discountable() | |||
There was a problem hiding this comment.
Could you please add a test demonstrating the issue you are describing?
There was a problem hiding this comment.
@specialunderwear I add picture for describe more and my branch already has tests added. Can you approve workflow for run test from github CI.
|
Hi there is a failing test: I think you need to update the fixtures to fix this. If you fix this we will review again. We are going to review pull requests weekly from now! You can run the tests by running |
|
Failed to push changes to this branch so reopened in #4102 4102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are product discountable true and variant discountable false in cart in the same time, discount is calculated for variant which is incorrect.