fix for #4049 #4050
Merged
fix for #4049 #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2023
|
@mghiglieri you have lint errors, probably the removed newline. |
|
@viggo-devries I added a newline at the end. |
viggo-devries
requested changes
Mar 1, 2023
| @@ -32,3 +32,4 @@ class ExpandDownwardsCategoryQueryset(Subquery): | |||
|
|
|||
| def as_sqlite(self, compiler, connection): | |||
| return super().as_sql(compiler, connection, self.template[1:-1]) | |||
|
|
|||
There was a problem hiding this comment.
Still a change here, please remove this change.
There was a problem hiding this comment.
Sorry, just changed it. No changes after line 19.
viggo-devries
approved these changes
May 5, 2023
viggo-devries
added a commit
that referenced
this pull request
May 5, 2023
|
@mghiglieri unfortunately this breaks gives a syntax error in postgres. |
|
you would have to make this work in both postgres and mysql @mghiglieri this was reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4049 and probably for #4032