Only create attributevalues that are dirty (#4250)

django-oscar · Feb 22, 2024 · a361765 · a361765
1 parent fee973c
commit a361765
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/oscar/apps/catalogue/product_attributes.py b/src/oscar/apps/catalogue/product_attributes.py
@@ -249,7 +249,8 @@ def prepare_save(self):
                         )
 
                         bound_value_obj = attribute.bind_value(new_value_obj, value)
-                        if bound_value_obj is not None:
+                        # don't create attributevalues that wheren't even set at all.
+                        if bound_value_obj is not None and bound_value_obj.is_dirty:
                             assert not bound_value_obj.pk
                             to_be_created.append(bound_value_obj)
                     else: