Increase performance on find_existing_attribute_option_group query #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specialunderwear
requested changes
Apr 12, 2024
There was a problem hiding this comment.
@viggo-devries this code is non working, see the test results
specialunderwear
requested changes
May 15, 2024
oscarapi/utils/exists.py
Outdated
| @@ -57,9 +57,8 @@ def find_existing_attribute_option_group(name, options): | |||
| AttributeOptionGroup.objects.filter(name=name) | |||
| .annotate(options_count=models.Count("options")) | |||
| .filter(options_count=len(options)) | |||
| .filter(options__option__in=options) | |||
There was a problem hiding this comment.
why 2 times filter?
why not
.filter(options_count=len(options), options__option__in=options)
When trying to create alot of options this is really slow
viggo-devries
force-pushed
the
improve_attributoptiongroup_query
branch
from
34e5a05
to
f65e2e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to create alot of options this is really slow