Add file extension for infile #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed the infile to have a file extension for integrating with requirejs. the optimizer 'r.js' requires the module 'name' to have a .js file extension.
Actually used suffix for temp file.
Good god, typo.
|
I'm not sure I understand, why do you need the temporary file to have an extension? |
|
Say that {input} is "/tmp/someTemp" . The requirejs optimizer takes in "/tmp/someTemp" as its module ( at this point it has no need for the extension ). It just assumes that the temp file is a javascript file with a '.js' extension. It then looks for the file "/tmp/someTemp.js" and sees that it doesn't exist and fails. Adding an extension to the temporary file fixes this. |
|
I don't see any reason not to do this, but this needs tests and rebasing against current develop. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to keep the file extension when loading a temporary file for filters.
I use this for integrating with require.js