Replace get_storage_class with new storages API for Django >= 4.2 #1216
+24
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #1187 I've created a helper function
_get_storage_class
which detects whether to use the old or new API depending on the current Django version.I've updated the code, and tests, to use this for now. Then when Django 4.1 support is dropped, it can be removed in favour of directly using
storages.create_storage
.I also updated the docs about custom remote storages, so people know to use the new API if they are using Django >= 4.2